Browse Source

feat(PR) add template

nothingismagick 6 years ago
parent
commit
77961611b6
1 changed files with 10 additions and 6 deletions
  1. 10 6
      .github/PULL_REQUEST_TEMPLATE.md

+ 10 - 6
.github/PULL_REQUEST_TEMPLATE.md

@@ -1,34 +1,38 @@
 <!--
 Please make sure to read the Pull Request Guidelines:
-https://github.com/quasarframework/quasar/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
+https://github.com/quasarframework/proton/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
 -->
 
 <!-- PULL REQUEST TEMPLATE -->
 <!-- (Update "[ ]" to "[x]" to check a box) -->
 
 **What kind of change does this PR introduce?** (check at least one)
+<!--
+If you are introducing a new binding, you must reference an issue where this binding has been proposed, discussed and approved by the maintainers.
+-->
 
 - [ ] Bugfix
 - [ ] Feature
+- [ ] New Binding Issue #___
 - [ ] Code style update
 - [ ] Refactor
 - [ ] Build-related changes
 - [ ] Other, please describe:
 
 **Does this PR introduce a breaking change?** (check one)
+<!--
+If yes, please describe the impact and migration path for existing applications in an attached issue. Filing a PR with breaking changes that has not been discussed and approved by the maintainers in an issue will be immediately closed.
+-->
 
-- [ ] Yes
+- [ ] Yes. Issue #___
 - [ ] No
 
-If yes, please describe the impact and migration path for existing applications:
 
 **The PR fulfills these requirements:**
 
 - [ ] It's submitted to the `dev` branch and _not_ the `master` branch
 - [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix: #xxx[,#xxx]`, where "xxx" is the issue number)
-- [ ] It's been tested on a Cordova (iOS, Android) app
-- [ ] It's been tested on a Electron app
-- [ ] Any necessary documentation has been added or updated [in the docs](https://github.com/quasarframework/quasar/tree/dev/docs) (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.
+- [ ] Any necessary documentation has been added or updated [in the docs](https://github.com/quasarframework/proton/tree/dev/docs) (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.
 
 If adding a **new feature**, the PR's description includes:
 - [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)